fix: make block query cutoff properly configurable #181
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
Actually, disregard the other review. This should be called BLOCK_QUERY_CUTOFF_BUFFER
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
seconds is not enough resolution. needs to be milliseconds
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
aa0fb98 to
48769bd
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
d6fa407 to
376d078
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
cb227d0 to
376d078
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
88c0627 to
c7121a6
Compare
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
I wonder if it's better to explicitly circuit break the building process altogether if the deadline ends up being too close to Instant::now() instead of this being implicit, because it indicates we've ran out of time anyway.
|
converting to draft until the duration math is removed and the bin-base changes are in |
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
99a5e4a to
aee5c4a
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
aee5c4a to
1e71f4f
Compare
|
this is unblocked now, no? |
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
1e71f4f to
308f138
Compare
|
This is ready for another round of review now that |
fix: make block query cutoff properly configurable
At some point in the past, the block query cutoff configuration value was removed and a hard-coded value was added in.
This PR adds the block query cutoff back into the config and uses the config value in the
calculate_deadline function.Builder example environment documentation needs to be updated to reflect this change.